Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename filters #4038

Closed
wants to merge 2 commits into from
Closed

Rename filters #4038

wants to merge 2 commits into from

Conversation

snan
Copy link

@snan snan commented Dec 29, 2022

New names for the filters. Keep on tweaking 'em if you don't like them, I just pulled them out of a hat πŸ€·πŸ»β€β™€οΈ

@bunnybones1
Copy link

Ludwig should be renamed to Beethoven

@snan
Copy link
Author

snan commented Dec 29, 2022

Ludwig should be renamed to Beethoven

That's fine by me. I thought it might be a li'l on the nose so I went with Wendy as per https://en.wikipedia.org/wiki/Koopalings

@juliloving
Copy link

1977 should be renamed to Orwell (because 1984 the book)

@snan
Copy link
Author

snan commented Dec 30, 2022

1977 should be renamed to Orwell (because 1984 the book)

That's fine by me. I was thinking that was a bit unappealing/boot-in-face-y for a photo-beautifier. So I turned to this 1977 movie character.

Ultimately if people wanna bikeshed about this then IDC. I'll unsubscribe and this'll just be a drive by contribution. That's fine too. πŸ€·πŸ»β€β™€οΈ
I haven't heard anything from the Pixelfed team.

@juliloving
Copy link

I didn't know Luke was a reference to anything, sorry :)

I hope team pixelfed responds because the issue at hand (legal matter) is a big deal

@floscher
Copy link

floscher commented Dec 30, 2022

The maintainers came up with another set of changes to the filters: https://mastodon.social/@dansup/109605006708970886

@snan
Copy link
Author

snan commented Dec 31, 2022

Obviously the names selected by team members are what you're gonna go with and that's fine, that's a good idea, so I'll close the PR.

But referring to that as "already on the way" is misleading and dishonest and cruel since I submitted this way before.🀬 I submitted this PR just hours after the i1977, iAdon, iAmaro version was published.

@snan snan closed this Dec 31, 2022
@floscher
Copy link

I'm sorry if this came across as rude. I have no affiliation with the project and just stumbled on that post, so I thought I'd let you know, since it seemed you were unaware.

It was just meant as a factual description that the post sounds like the changes would go live within a few hours. Should have worded that better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants